BUG: CommonC++ includes compile time $CFLAGS in ccgnu2-config --flags

[Curtis Magyar]

http://bugs.gentoo.org/show_bug.cgi?id=58515

I guess I should report this bug here too.  I filed it with the Gentoo
bugzilla, but the patch should go upstream I think because this
behaviour is very bad.

The problem is that if common c++ is compiled with $CFLAGS set, the
ccgnu2-config script, and the pkg-config stuff in the devel branch both
pass the CommonC++ compile time $CFLAGS on to anything compiled using
those scripts.

There's a patch for 1.0.13 stable branch here:
http://bugs.gentoo.org/attachment.cgi?id=36245&action=view

and I'll attach a patch for 1.2.4 that fixes ccgnu2-config, as well as
the pkg-config files libccgnu2.pc and libccext2.pc.

Hopefully this will save someone else a bunch of time hunting down stray
-march='s in their projects $CFLAGS.

Additionally (and unrelated to this bug), would it not be helpful if
these two pkg-config files were called ccgnu2-1.2.pc and ccext2-1.2.pc
to facilitate having multiple versions of the libraries installed?
And the 'lib' prefix should be implied by the fact you're using the
scripts in the first place.


--
Curtis Magyar

--- commoncpp2-1.2.4-orig/src/ccgnu2-config.in  2004-05-30 10:12:55.000000000 
-0500
+++ commoncpp2-1.2.4/src/ccgnu2-config.in       2004-07-27 02:03:36.874432168 
-0500
@@ -11,7 +11,7 @@
 
 ost_cv_dynloader="@ost_cv_dynloader@"      
 modflags="@MODULE_FLAGS@"
-ccflags="@THREAD_FLAGS@ @CXXFLAGS@"
+ccflags="@THREAD_FLAGS@"
 cclink="@SOCKET_LIBS@ @GETOPT_LIBS@ @THREAD_LIBS@"
 ccload="@DYN_LOADER@"
 ccstd="@XML_LIBS@ @ZSTREAM_LIBS@"
@@ -84,4 +84,3 @@
        esac
        shift
 done
-
--- commoncpp2-1.2.4-orig/src/libccgnu2.pc.in   2004-06-02 12:28:07.000000000 
-0500
+++ commoncpp2-1.2.4/src/libccgnu2.pc.in        2004-07-27 01:22:10.340442792 
-0500
@@ -8,5 +8,4 @@
 Description: GNU Common C++ core library
 Version: @VERSION@
 Libs:  -lccgnu2 @DYN_LOADER@ @SOCKET_LIBS@ @GETOPT_LIBS@ @THREAD_LIBS@ 
-Cflags: @THREAD_FLAGS@ @CXXFLAGS@ address@hidden@
- 
+Cflags: @THREAD_FLAGS@ address@hidden@
--- commoncpp2-1.2.4-orig/src/libccext2.pc.in   2004-06-02 12:19:53.000000000 
-0500
+++ commoncpp2-1.2.4/src/libccext2.pc.in        2004-07-27 01:22:19.161101848 
-0500
@@ -8,5 +8,4 @@
 Version: @VERSION@
 Requires: libccgnu2 = @VERSION@, libxml-2.0
 Libs: -lccext2
-Cflags: @THREAD_FLAGS@ @CXXFLAGS@
- 
+Cflags: @THREAD_FLAGS@