Re: [PATCH] chroot specify user/group feature

[Eric Blake]

Giuseppe Scrivano <gscrivano <at> gnu.org> writes:

> > setuidgid appears to be subsumed by chroot with the new options.
> > If we can remove setuidgid.c, that code is no longer duplicated,
> > so there's less (no?) motivation to move it into gnulib.
> 
> If you want to remove setuidgid then I don't see any reason to move
> the shared code into gnulib.  Though I have to admit it sounds a bit
> strange to use chroot to change uid/gid, maybe rewrite setuidgid as a
> wrapper around chroot?

The point is that setuidgid is not installed.  It exists only for the purposes 
of the testsuite.  If it were an installed app, then yes it would make sense to 
keep it around, although perhaps rewritten as a wrapper around the new chroot 
functionality.  But since setuidgid is not installed, while chroot is, there is 
no longer any incentive to even have setuidgid in the first place.  By using 
chroot in the first place, the testsuite would be a) adding to the coverage of 
chroot features, and b) minimizing reliance on software that gets no testing 
outside of the testsuite, both of which are good moves.

-- 
Eric Blake