[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [bug-gawk] array methods belong in a struct, not an array
From: |
Andrew J. Schorr |
Subject: |
Re: [bug-gawk] array methods belong in a struct, not an array |
Date: |
Sun, 6 Jan 2019 09:46:24 -0500 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
Hi,
On Sun, Jan 06, 2019 at 05:30:16AM -0700, address@hidden wrote:
> "Andrew J. Schorr" <address@hidden> wrote:
>
> > I propose the attached patch that removes the alength function and cleans
> > up this issue.
>
> This is OK, but is not quite complete. There are, I think, two uses
> in symbol.c and one in gawkapi.c where direct access to xxx->table_size
> should be replaced by assoc_empty. Please fix those as well and then
> push to master.
I pushed it to master. Note that it does not include the array type
resetting patch. Do you want that one in master or in stable?
> > But taking another step back, I'm not sure why these array methods are
> > implemented as an array of function pointers instead of as a struct
> > with a field for each method.
>
> This would be a step forward. If you can work up a patch for that for
> review, I'd appreciate it.
Attached.
Regards,
Andy
array.patch
Description: Text document
- Re: [bug-gawk] array initialization, (continued)
- Re: [bug-gawk] array initialization, Wolfgang Laun, 2019/01/05
- Re: [bug-gawk] array initialization, Andrew J. Schorr, 2019/01/05
- Re: [bug-gawk] array initialization, Andrew J. Schorr, 2019/01/05
- Re: [bug-gawk] array initialization, arnold, 2019/01/05
- Re: [bug-gawk] array initialization, Andrew J. Schorr, 2019/01/05
- Re: [bug-gawk] useless array length abstraction, Andrew J. Schorr, 2019/01/05
- Re: [bug-gawk] useless array length abstraction, arnold, 2019/01/06
- Re: [bug-gawk] useless array length abstraction, Andrew J. Schorr, 2019/01/06
- Re: [bug-gawk] useless array length abstraction, arnold, 2019/01/06
- Re: [bug-gawk] useless array length abstraction, Andrew J. Schorr, 2019/01/06
- Re: [bug-gawk] array methods belong in a struct, not an array,
Andrew J. Schorr <=
- Re: [bug-gawk] array methods belong in a struct, not an array, arnold, 2019/01/06
- Re: [bug-gawk] array initialization, arnold, 2019/01/05
- Re: [bug-gawk] array initialization, Andrew J. Schorr, 2019/01/05
Re: [bug-gawk] array initialization, arnold, 2019/01/05