bug-gnu-emacs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#7308: [patch] locate under windoze


From: Eduard Wiebe
Subject: bug#7308: [patch] locate under windoze
Date: Sat, 13 Nov 2010 23:33:08 +0100
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (gnu/linux)

Eli Zaretskii <address@hidden> writes:

>> From: Chong Yidong <address@hidden>
>> Cc: Eduard Wiebe <address@hidden>, address@hidden
>> Date: Sat, 13 Nov 2010 13:57:03 -0500
>> 
>> Eduard Wiebe <address@hidden> writes:
>> 
>> > Eduard Wiebe <address@hidden> writes:
>> >
>> > Ping.
>> 
>> Eli, are you happy with the patch introducing the backslash changes from
>> 
>>  http://debbugs.gnu.org/cgi/bugreport.cgi?bug=7308#50
>> 
>> ?  It looks OK to me, but I am not sure I've correctly followed the
>> discussion in this bug report.
>
> I'm okay with the main change, but I don't understand the reason (or
> need) for this hunk:
>
>   @@ -473,9 +483,9 @@ do not work in subdirectories.
>      (make-local-variable 'directory-listing-before-filename-regexp)
>      ;; This should support both Unix and Windoze style names
>      (setq directory-listing-before-filename-regexp
>   -   (concat "^."
>   +   (concat "^.\\("
>                 (make-string (1- locate-filename-indentation) ?\s)
>   -           "\\(/\\|[A-Za-z]:\\)\\|"
                ^^^^^^^^^^^^^^^^^^^^

>   +            "\\)\\|"
>                 (default-value 'directory-listing-before-filename-regexp)))
>      (make-local-variable 'dired-actual-switches)
>      (setq dired-actual-switches "")

This hunk is essential.  The new value of the regexp avoids the
truncation of the drive letter from absolute path of the selected file.

Btw. Under GNU/Linux this change leads to correct position of cursor in
*Locate* buffer, too.

PS: I tested my patch under GNU/Linux with GNU locate und MS-Windows
with everything-Tool for a while and it works fine.

-- 
Eduard Wiebe





reply via email to

[Prev in Thread] Current Thread [Next in Thread]