bug-gnu-emacs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#7308: [patch] locate under windoze


From: Eli Zaretskii
Subject: bug#7308: [patch] locate under windoze
Date: Sun, 14 Nov 2010 05:59:17 +0200

> From: Eduard Wiebe <address@hidden>
> Cc: Chong Yidong <address@hidden>, address@hidden
> Date: Sat, 13 Nov 2010 23:33:08 +0100
> 
> > I'm okay with the main change, but I don't understand the reason (or
> > need) for this hunk:
> >
> >   @@ -473,9 +483,9 @@ do not work in subdirectories.
> >      (make-local-variable 'directory-listing-before-filename-regexp)
> >      ;; This should support both Unix and Windoze style names
> >      (setq directory-listing-before-filename-regexp
> >   - (concat "^."
> >   + (concat "^.\\("
> >               (make-string (1- locate-filename-indentation) ?\s)
> >   -         "\\(/\\|[A-Za-z]:\\)\\|"
>                 ^^^^^^^^^^^^^^^^^^^^
> 
> >   +          "\\)\\|"
> >               (default-value 'directory-listing-before-filename-regexp)))
> >      (make-local-variable 'dired-actual-switches)
> >      (setq dired-actual-switches "")
> 
> This hunk is essential.  The new value of the regexp avoids the
> truncation of the drive letter from absolute path of the selected file.
> 
> Btw. Under GNU/Linux this change leads to correct position of cursor in
> *Locate* buffer, too.

Sorry, I still don't understand: what truncation? what incorrect
position?  Please explain more.

> PS: I tested my patch under GNU/Linux with GNU locate und MS-Windows
> with everything-Tool for a while and it works fine.

I never doubted that you tested the change.  I just want to understand
it.





reply via email to

[Prev in Thread] Current Thread [Next in Thread]