[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [bug-gnulib] gnulib taking over libobjs?
From: |
Bruno Haible |
Subject: |
Re: [bug-gnulib] gnulib taking over libobjs? |
Date: |
Thu, 5 Oct 2006 19:48:12 +0200 |
User-agent: |
KMail/1.9.1 |
Simon Josefsson wrote:
> Here is a working prototype. It solved the problem with two gnulib
> directories for me in libidn, i.e., no more complaints that AC_LIBOBJ
> files are not found in all gnulib directories.
Very well!
> @@ -1922,7 +1925,34 @@
> echo " ${libname_upper}_LTLIBDEPS=\"\$gl_ltlibdeps\""
> echo " AC_SUBST([${libname_upper}_LTLIBDEPS])"
> fi
> + echo " m4_popdef([AC_REPLACE_FUNCS])"
> + echo " m4_popdef([AC_LIBOBJ])"
> + echo " AC_CONFIG_COMMANDS_PRE(["
> + echo " ${macro_prefix}_libobjs="
> + echo " ${macro_prefix}_ltlibobjs="
> + echo " for ac_i in : \$${macro_prefix}_LIBOBJS; do test \"x\$ac_i\" =
> x: && continue"
> + echo " # 1. Remove the extension, and \$U if already installed."
> + echo " ac_script='s/\\\$U\././;s/\.o\$//;s/\.obj\$//'"
> + echo " ac_i=\`echo \"\$ac_i\" | sed \"\$ac_script\"\`"
> + echo " # 2. Prepend LIBOBJDIR. When used with automake>=1.10
> LIBOBJDIR"
> + echo " # will be set to the directory where
> ${macro_prefix}_LIBOBJS objects are built."
> + echo " ${macro_prefix}_libobjs=\"\$${macro_prefix}_libobjs
> \\\${LIBOBJDIR}\$ac_i\\\$U.\$ac_objext\""
> + echo " ${macro_prefix}_ltlibobjs=\"\$${macro_prefix}_ltlibobjs
> \\\${LIBOBJDIR}\$ac_i\"'\$U.lo'"
> + echo " done"
I would use 'i' and 'sed_drop_objext' instead of the two identifiers
starting with ac_. The prefix ac_ should be reserved to autoconf.
I wouldn't use $U, because it's not a documented internal of autoconf.
And we don't need it since we assume ANSI C.
The use of LIBOBJDIR is wrong; you need to use ${sourcebase} instead.
(Because there can be only one LIBOBJDIR per configure script, and
we are doing this effort precisely to use several gnulib-tool invocations
in a single configure script.)
Also, when you're done with the modification in func_import, please do the
same to func_create_testdir, so that any problems that some modules might
have in func_import already show up in func_create_testdir.
Bruno
- Re: gnulib taking over libobjs?, James Youngman, 2006/10/05
- Re: [bug-gnulib] gnulib taking over libobjs?, Bruno Haible, 2006/10/05
- Re: [bug-gnulib] gnulib taking over libobjs?, Simon Josefsson, 2006/10/05
- Re: gnulib taking over libobjs?, Simon Josefsson, 2006/10/05
- Re: [bug-gnulib] gnulib taking over libobjs?,
Bruno Haible <=
- Re: gnulib taking over libobjs?, Simon Josefsson, 2006/10/10
- Re: gnulib taking over libobjs?, Simon Josefsson, 2006/10/10
- Re: gnulib taking over libobjs?, Ralf Wildenhues, 2006/10/10
- Re: gnulib taking over libobjs?, Simon Josefsson, 2006/10/10
- Re: [bug-gnulib] gnulib taking over libobjs?, Bruno Haible, 2006/10/12
- Re: [bug-gnulib] gnulib taking over libobjs?, Bruno Haible, 2006/10/12
- Re: gnulib taking over libobjs?, Jim Meyering, 2006/10/12
- Re: gnulib taking over libobjs?, Bruno Haible, 2006/10/12
- Re: gnulib taking over libobjs?, Jim Meyering, 2006/10/12
- Re: gnulib taking over libobjs?, Jim Meyering, 2006/10/12