[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH]: glthread cond win32 compilation problem

From: Bruno Haible
Subject: Re: [PATCH]: glthread cond win32 compilation problem
Date: Sat, 13 Sep 2008 11:58:17 +0200
User-agent: KMail/1.5.4

Yoann Vandoorselaere replied
> > About the second hunk, the problem is more general: not only on mingw,
> > but on all platforms which lack ETIMEDOUT, one needs a substitute. It
> > can be a random positive number. I propose this patch instead.

Not applied. Errno values are better defined in <errno.h> or <config.h>, after

> > Additionally, the use of "#define ETIMEDOUT ETIME" in the Solaris case is
> > incorrect: Solaris has ETIMEDOUT, and it's a no-no to redefine errno
> > values in header files that user code may include. I propose this instead:
> Your modified patch look good, apply?

I applied the Solaris specific change.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]