[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] implement full-blown select(2) for winsock

From: Simon Josefsson
Subject: Re: [PATCH] implement full-blown select(2) for winsock
Date: Tue, 23 Sep 2008 16:14:01 +0200
User-agent: Gnus/5.110011 (No Gnus v0.11) Emacs/22.2 (gnu/linux)

Paolo Bonzini <address@hidden> writes:

> Tested under Wine.  I'd appreciate more testing before committing it.

I don't think this code should be built just because someone wanted the
sys/socket.h header and added the sys_socket module.  There are many
places you want the sys/socket.h header without calling select.

Instead, please put this code in a new module 'select', or possibly
'mingw-select' to denote it is mingw specific.  Of course, sys_socket
needs to be teached to declare the proper prototypes when the
(mingw)select module is enabled.  Compare other header files and system
functions for how to do it, e.g., stdio.in.h and fopen: the replacement
for fopen isn't pulled in by the stdio-h module normally, but the
stdio.in.h code helps the fopen module when in use.

Possibly this argument applies to the winsock.c code as well, but I
haven't looked into it.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]