[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] printf-parse: pull in features.h for __GLIBC__
From: |
Bruno Haible |
Subject: |
Re: [PATCH] printf-parse: pull in features.h for __GLIBC__ |
Date: |
Fri, 19 Nov 2010 01:40:34 +0100 |
User-agent: |
KMail/1.9.9 |
Hi Mike,
> --- a/lib/printf-parse.h
> +++ b/lib/printf-parse.h
> @@ -25,6 +25,9 @@
>
> #include "printf-args.h"
>
> +#ifdef HAVE_FEATURES_H
> +# include <features.h> /* for __GLIBC__ */
> +#endif
>
> /* Flags */
> #define FLAG_GROUP 1 /* ' flag */
Why should this be needed? printf-args.h include <wchar.h> and,
<wchar.h> includes <features.h>. Admittedly this is thin ice, but in
general we know that every glibc header file includes <features.h>.
Bruno
Re: [PATCH] printf-parse: pull in features.h for __GLIBC__, Bruno Haible, 2010/11/20