[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] Avoid one "parameter unused" warnings.
From: |
Michal Privoznik |
Subject: |
Re: [PATCH] Avoid one "parameter unused" warnings. |
Date: |
Mon, 1 Jan 2018 12:56:21 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.0 |
On 01/01/2018 10:53 AM, Paul Eggert wrote:
> Thanks, but -Wunused-parameter issues so many false alarms that I think
> I'd rather just ask people to compile with -Wno-unused-parameter. That's
> what coreutils does, and Emacs, and so forth.
Can you elaborate on this please? I'm failing to see why this would be a
false positive. Despite this function being inlined, compiler might
decide to not inline it and thus treat it as any other function in which
case the variable is unused indeed.
>
> By the way, this thread duplicates one of a couple of days ago, starting
> here:
>
> http://lists.gnu.org/archive/html/bug-gnulib/2017-12/msg00077.html
Ah, haven't noticed, sorry.
>
> Is there some new project using Gnulib that is causing these new
> messages? If so, perhaps I should propose a patch to it to pacify GCC
> without having to pollute the code with void no-op casts.
Yes, libvirt. However, libvirt's no newbie to gnulib. We've used it for
ages.
Michal
Re: [PATCH] Avoid one "parameter unused" warnings., Eric Blake, 2018/01/02
- [PATCH v2] stat-time: silence -Wunused-parameter regression, Eric Blake, 2018/01/02
- Re: [PATCH v2] stat-time: silence -Wunused-parameter regression, Jim Meyering, 2018/01/02
- Re: [PATCH v2] stat-time: silence -Wunused-parameter regression, Paul Eggert, 2018/01/02
- Re: [PATCH v2] stat-time: silence -Wunused-parameter regression, Tim Rühsen, 2018/01/03
- -Wundef in *.h [was: [PATCH v2] stat-time: silence -Wunused-parameter regression], Eric Blake, 2018/01/03