[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v2] stat-time: silence -Wunused-parameter regression

From: Tim Rühsen
Subject: Re: [PATCH v2] stat-time: silence -Wunused-parameter regression
Date: Wed, 3 Jan 2018 11:53:40 +0100
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.2

... here is another one in lib/cdef.h occurring with a  MinGW build.

In file included from ../lib/libc-config.h:149:0,
                 from ../lib/glob.h:24,
                 from utils.c:35:
../lib/cdefs.h:298:6: warning: "__USE_FORTIFY_LEVEL" is not defined,
evaluates to 0 [-Wundef]

With Best Regards, Tim

On 01/03/2018 02:27 AM, Jim Meyering wrote:
> On Tue, Jan 2, 2018 at 1:56 PM, Eric Blake <address@hidden> wrote:
>> Commit 2c5d5587 causes warnings on non-Sun systems when compiled
>> under -Wunused-parameter; we've previously tweaked code in commit
>> 81eb8486 to avoid such warnings.  Prefer an attribute rather than
>> a cast to void (the attribute is always okay to apply; gcc
>> interprets it as 'may be unused', not 'must not be used', precisely
>> to cater to #if chains where determining whether or not the
>> parameter is used gets hairy).
>> * lib/stat-time.h (get_stat_birthtime_ns, get_stat_birthtime):
>> Prefer attribute over cast-to-void.
>> (stat_time_normalize): Mark st as potentially unused.
> Thanks. That sounds like the right approach. We have to hold
> user-included headers to a higher standard.

Attachment: 0001-Fix-Wundef-in-user-included-header-lib-cdef.h.patch
Description: Text Data

Attachment: signature.asc
Description: OpenPGP digital signature

reply via email to

[Prev in Thread] Current Thread [Next in Thread]