bug-grep
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 30/34] maint: dfa: simplify several expressions


From: Paolo Bonzini
Subject: Re: [PATCH 30/34] maint: dfa: simplify several expressions
Date: Thu, 15 Sep 2011 13:52:18 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:6.0.2) Gecko/20110906 Thunderbird/6.0.2

On 09/15/2011 01:29 PM, Jim Meyering wrote:
>  d->mb_cur_max = MBS_SUPPORT ? MB_CUR_MAX : 1
That's tempting, but not needed.
MB_CUR_MAX is already defined appropriately, so what's there is fine:

        d->mb_cur_max = MB_CUR_MAX;


Yes, I'm suggesting to drop the "appropriate definition" (patch 22) for now. It was too clever for me to grasp it, so I need separate convincing. :)

Paolo



reply via email to

[Prev in Thread] Current Thread [Next in Thread]