[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 2/8] Avoid hashing garbage for short keynames.
From: |
olafBuddenhagen |
Subject: |
Re: [PATCH 2/8] Avoid hashing garbage for short keynames. |
Date: |
Fri, 13 Aug 2010 08:59:57 +0200 |
User-agent: |
Mutt/1.5.20 (2009-06-14) |
Hi,
On Wed, Aug 11, 2010 at 07:04:17PM -0300, Diego Nieto Cid wrote:
> 2010/8/9 <olafBuddenhagen@gmx.net>:
> > Hm, why tmp[5]? The way I read the code, only 4 entries are used...
>
> Well it's the null that terminates the string.
But you specified "4" in the strncpy()... AFAIK it will omit the \0 if
there are 4 non-\0 characters. If you wanted to preserve the \0, you'd
have to use "5" in both places. However, ...
> But as this isn't used as a string it probably does not make much
> sense.
Indeed.
-antrik-
- [PATCH 1/5] Add type to $$ in mid-rules., (continued)
- [PATCH 1/5] Add type to $$ in mid-rules., Diego Nieto Cid, 2010/08/11
- [PATCH 2/5] Lexer support for keycodes with +/- symbols and arbitrary level numbers., Diego Nieto Cid, 2010/08/11
- [PATCH 3/5] Skip to main file's default section when needed., Diego Nieto Cid, 2010/08/11
- [PATCH 4/5] Update key type assigment routine., Diego Nieto Cid, 2010/08/11
- [PATCH 5/5] Recreate xkb/keymap/hurd from xkeyboard-config-1.8's xfree86 keymap., Diego Nieto Cid, 2010/08/11
- [PATCH 4/8] Remove glue code and use mig to regenerate it., Diego Nieto Cid, 2010/08/04
- [PATCH 3/8] Rule vmod returns an int with the vmod's bit on., Diego Nieto Cid, 2010/08/04
- [PATCH 2/8] Avoid hashing garbage for short keynames., Diego Nieto Cid, 2010/08/04
- [PATCH 5/8] Update code borrowed from console-client., Diego Nieto Cid, 2010/08/04
- [PATCH 6/8] Add missing functions to input_driver_test., Diego Nieto Cid, 2010/08/04
- [PATCH 7/8] Argument's default values are set independently., Diego Nieto Cid, 2010/08/04
- [PATCH 8/8] Use vfprintf in debug_printf and write to stderr., Diego Nieto Cid, 2010/08/04
- Re: [PATCH 0/8] Bring console-driver-xkb up to date, olafBuddenhagen, 2010/08/11