bug-hurd
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 2/8] Avoid hashing garbage for short keynames.


From: Carl Fredrik Hammar
Subject: Re: [PATCH 2/8] Avoid hashing garbage for short keynames.
Date: Sat, 14 Aug 2010 13:42:53 +0200
User-agent: Mutt/1.5.20 (2009-06-14)

Hi,

On Wed, Aug 11, 2010 at 07:04:17PM -0300, Diego Nieto Cid wrote:
> Hi,
> 
> 2010/8/9  <address@hidden>:
> >
> > Hm, why tmp[5]? The way I read the code, only 4 entries are used...
> >
> 
> Well it's the null that terminates the string. But as this isn't used
> as a string it probably does not make much sense.

Not sure if this isn't already obvious to you but if it's not a string
then you should also use memcpy() instead of strncpy().

Regards,
  Fredrik



reply via email to

[Prev in Thread] Current Thread [Next in Thread]