bug-hurd
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH,HURD] hurd: compliance fixes for getgroups


From: Roland McGrath
Subject: Re: [PATCH,HURD] hurd: compliance fixes for getgroups
Date: Fri, 27 Apr 2012 14:54:02 -0700 (PDT)

> 2012-04-27  Pino Toscano  <address@hidden>
>
>       * sysdeps/mach/hurd/getgroups.c (__getgroups): Return -1 and set EINVAL
>       for negative `n' or less than `ngids'.

The norm is to use all caps and no quotes to mention local variable
names.  You can also drop the (function) when it's the only function
in the file of the same name.

The change itself is fine by me.  Since I see you already have
copyright paperwork and you're doing more than just the one change,
would you like to get set up to commit yourself?


Thanks,
Roland



reply via email to

[Prev in Thread] Current Thread [Next in Thread]