[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 1/6] libdiskfs: remove dead assignment
From: |
Samuel Thibault |
Subject: |
Re: [PATCH 1/6] libdiskfs: remove dead assignment |
Date: |
Sat, 16 Nov 2013 11:17:30 +0100 |
User-agent: |
Mutt/1.5.21+34 (58baf7c9f32f) (2010-12-30) |
Justus Winter, le Sat 16 Nov 2013 10:58:14 +0100, a écrit :
> Found using the Clang Static Analyzer.
>
> * libdiskfs/io-write.c (diskfs_S_io_write): Remove dead assignment.
Ack
> ---
> libdiskfs/io-write.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/libdiskfs/io-write.c b/libdiskfs/io-write.c
> index 26e0be4..2967c4c 100644
> --- a/libdiskfs/io-write.c
> +++ b/libdiskfs/io-write.c
> @@ -56,7 +56,6 @@ diskfs_S_io_write (struct protid *cred,
> goto out;
> }
>
> - err = 0;
> while (off + (off_t) datalen > np->allocsize)
> {
> err = diskfs_grow (np, off + datalen, cred);
> --
> 1.7.10.4
>
--
Samuel
N: beep beep Miam miam?
y: ++
a: kill -MIAM -1
- Clang Static Analyzer reports & more fixes for the Hurd, Justus Winter, 2013/11/16
- [PATCH 1/6] libdiskfs: remove dead assignment, Justus Winter, 2013/11/16
- Re: [PATCH 1/6] libdiskfs: remove dead assignment,
Samuel Thibault <=
- [PATCH 2/6] libdiskfs: fix error handling, Justus Winter, 2013/11/16
- [PATCH 4/6] libshouldbeinlibc: fix dead assignment, Justus Winter, 2013/11/16
- [PATCH 3/6] ext2fs: fix error handling, Justus Winter, 2013/11/16
- [PATCH 6/6] mach-defpager: do not remove -Wall from CFLAGS, Justus Winter, 2013/11/16
- [PATCH 5/6] mach-defpager: fix the page offsets returned by pager_pages, Justus Winter, 2013/11/16