[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 3/6] ext2fs: fix error handling
From: |
Samuel Thibault |
Subject: |
Re: [PATCH 3/6] ext2fs: fix error handling |
Date: |
Sat, 16 Nov 2013 11:20:27 +0100 |
User-agent: |
Mutt/1.5.21+34 (58baf7c9f32f) (2010-12-30) |
Justus Winter, le Sat 16 Nov 2013 10:58:16 +0100, a écrit :
> Found using the Clang Static Analyzer.
>
> * ext2fs/dir.c (diskfs_lookup_hard): Fix error handling.
Ack.
> ---
> ext2fs/dir.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/ext2fs/dir.c b/ext2fs/dir.c
> index c075246..a7eeaaa 100644
> --- a/ext2fs/dir.c
> +++ b/ext2fs/dir.c
> @@ -195,6 +195,8 @@ diskfs_lookup_hard (struct node *dp, const char *name,
> enum lookup_type type,
> err = vm_map (mach_task_self (),
> &buf, buflen, 0, 1, memobj, 0, 0, prot, prot, 0);
> mach_port_deallocate (mach_task_self (), memobj);
> + if (err)
> + return err;
>
> inum = 0;
>
> --
> 1.7.10.4
>
--
Samuel
<y> ça gaze ?
<l> prout
-+- #ens-mim - ouvrez les fenêtres ! -+-
- Clang Static Analyzer reports & more fixes for the Hurd, Justus Winter, 2013/11/16
- [PATCH 1/6] libdiskfs: remove dead assignment, Justus Winter, 2013/11/16
- [PATCH 2/6] libdiskfs: fix error handling, Justus Winter, 2013/11/16
- [PATCH 4/6] libshouldbeinlibc: fix dead assignment, Justus Winter, 2013/11/16
- [PATCH 3/6] ext2fs: fix error handling, Justus Winter, 2013/11/16
- Re: [PATCH 3/6] ext2fs: fix error handling,
Samuel Thibault <=
- [PATCH 6/6] mach-defpager: do not remove -Wall from CFLAGS, Justus Winter, 2013/11/16
- [PATCH 5/6] mach-defpager: fix the page offsets returned by pager_pages, Justus Winter, 2013/11/16
- Re: Clang Static Analyzer reports & more fixes for the Hurd, Samuel Thibault, 2013/11/16
- Re: Clang Static Analyzer reports & more fixes for the Hurd, Samuel Thibault, 2013/11/16
- Re: Clang Static Analyzer reports & more fixes for the Hurd, Marin Ramesa, 2013/11/16