[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Bug-wget] [PATCH] Replaced-xfree_null-by-xfree-and-nullify-argument
From: |
Giuseppe Scrivano |
Subject: |
Re: [Bug-wget] [PATCH] Replaced-xfree_null-by-xfree-and-nullify-argument-aftfer-freeing |
Date: |
Mon, 01 Dec 2014 12:59:26 +0100 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) |
Tim Rühsen <address@hidden> writes:
> This patch removes xfree_null() and replaces it by xfree().
> xfree() automatically nullifies the argument after freeing to reduce dangling
> pointer problems like double frees.
>
> I also cleaned up code like
> if (p)
> xfree (p);
>
> and
> xfree(p);
> p = NULL;
>
> Both cases reduce to a call to xfree(p).
>
> check and distcheck tested, also valgrind tested.
>
> Please review and comment.
>
> Tim
>
> From ede5a27de1e2e5447ec31a918af789e657b53b1b Mon Sep 17 00:00:00 2001
> From: Tim Ruehsen <address@hidden>
> Date: Sat, 29 Nov 2014 17:54:20 +0100
> Subject: [PATCH] Replaced xfree_null() by xfree() and nullify argument after
> freeing.
ACK
Regards,
Giuseppe
- Re: [Bug-wget] [PATCH] Replaced-xfree_null-by-xfree-and-nullify-argument-aftfer-freeing,
Giuseppe Scrivano <=