Re: quagga-0.96.3 compile problem

[Paul Jakma]

Hi Martin,

On Mon, 27 Oct 2003, Martin Kluge wrote:

> Hi,
> 
> I tried compiling quagge-0.96.3 under FreeBSD-5.1, but I got the
> error, that UINT32_MAX is undeclared in bgp_routemap.c (line 882
> and others).

Yep, that is fixed in CVS, hence will be fixed in 0.96.4.

> I think you should check for and include /usr/include/stdint.h on
> FreeBSD, which includes /usr/include/machine/_stdint.h which
> defines UINT32_MAX as 0xffffffffU.

Well, we include inttypes.h, which according to ISO C99 should 
include stdint.h.

FreeBSD needs to get out of the steam age and update its header
files. In the meantime though, there is a work around in Quagga.

> I don't know if /usr/include/stdint.h should be included with
> another header file, but a quick grep for stdint.h in /usr/include
> didn't come out with any header files you're checking for in the
> configure script.

inttypes.h.

> Directly including /usr/include/stdint.h in bgp_routemap.c fixed my
> problem, but I think you should update the configure.ac file
> instead.

Well, we now have a check for INT32_MAX being defined, and defining
it within Quagga if it was not already defined, lib/zebra.h:

/* Some systems do not define UINT32_MAX */
#ifndef UINT32_MAX
#define UINT32_MAX 0xFFFFFFFFU
#endif /* UINT32_MAX */

NB Kunihiro: GNU Zebra probably needs this too. (as well as adding 
inttypes.h to configure.ac CHECK_HEADERS()).

> Just my 2 cents :)

Well, my 2 cents would be that FreeBSD is antiquated :) (at least wrt 
to its header files.)
 
> Thanks,
> Martin

regards,
-- 
Paul Jakma      address@hidden  address@hidden  Key ID: 64A2FF6A
        warning: do not ever send email to address@hidden
Fortune:
"Nuclear war would really set back cable."
                -- Ted Turner