[Bug-zile] Re: [PATCH] Check `fchmod' and `fchown' return value.

[Reuben Thomas]

Thanks for the patch. The thing is, we really do not care if the operations succeed or fail. So, normally I would just cast the return value to void, but the GNU Coding Standards do not allow that.

Also, there is no need to fix both fchown and fchmod, as only one of them causes a warning.

What do you think?

On 2 March 2010 20:33, Giuseppe Scrivano <address@hidden> wrote:

This patch fixes the following compiler warning:

warning: ignoring return value of 'fchown', declared with attribute warn_unused_result

Cheers,
Giuseppe

-- 
http://rrt.sc3d.org