[Bug-zile] Re: [PATCH] Check `fchmod' and `fchown' return value.

[Giuseppe Scrivano]

Hi Reuben,

thanks for the quick feedback.  If we don't care if these operations
succeed or not, maybe we can just report the error and continue the
function execution?

I think it will be better to handle both functions in the same way as
they are complementary to each other.

Cheers,
Giuseppe


Reuben Thomas <address@hidden> writes:

> Thanks for the patch. The thing is, we really do not care if the operations 
> succeed or fail. So, normally I would just cast the return
> value to void, but the GNU Coding Standards do not allow that.
>
> Also, there is no need to fix both fchown and fchmod, as only one of them 
> causes a warning.
>
> What do you think?
>
> On 2 March 2010 20:33, Giuseppe Scrivano <address@hidden> wrote:
>
>     This patch fixes the following compiler warning:
>    
>     warning: ignoring return value of 'fchown', declared with attribute 
> warn_unused_result
>    
>     Cheers,
>     Giuseppe
>
> --
> http://rrt.sc3d.org