Re: [cp-patches] jni global ref patch

[Mark Wielaard]

Hi,

On Tue, 2005-02-01 at 16:36 -0700, Craig Black wrote:
> The attached patch fixes a couple of places where local jni references
> were being used with signal handlers. The patch also fixes an issue with
> state table entries being destroyed too soon. Comments?
>
> 2005-02-01  Craig Black  <address@hidden>
> 
>   * native/jni/gtk-peer/gnu_java_awt_peer_gtk_GdkGraphics.c
>   (copyState): Pass a JNI global reference to signal handler.
>   (realize_cb): Use and free JNI global reference.

For consistency with the rest of the source it would probably be good to
write this using the macros NSA_SET_GLOBAL_REF, NSA_GET_GLOBAL_REF in
copyState() and NSA_DEL_GLOBAL_REF in realize_cb.

>   * native/jni/gtk-peer/gnu_java_awt_peer_gtk_GtkChoicePeer.c
>   (create): Pass a JNI global reference to signal handler.
>   (selection_changed): Match declaration.
> 
>   * native/jni/gtk-peer/gnu_java_awt_peer_gtk_GtkGenericPeer.c
>   (dispose): Do not remove entries from state tables until after widget is
> destroyed.

This looks good. Please commit.
Thanks for catching these.

Cheers,

Mark

signature.asc
Description: This is a digitally signed message part