Re: [cp-patches] Patch: SwingUtilities.replaceUIActionMap fixed

[Roman Kennke]

Am Dienstag, den 08.11.2005, 15:39 -0500 schrieb Anthony Balkissoon:
> As I reported in bug 24742:
> http://gcc.gnu.org/bugzilla/show_bug.cgi?id=24742
> SwingUtilities.replaceUIActionMap wasn't working properly.  This patch
> fixes it and also fixes BasicListUI, BasicTableUI, and BasicTreeUI to
> use ActionMapUIResource for their ActionMaps as they should.

I see you attached a testcase for that. Could you please turn this into
a Mauve test and commit that too? For bugs I now nearly completely
follow this pattern:

- analyze bug
- think out a possible reason for the bug
- build a testcase that proves the above theory (often it is proven
wrong), helping to figure out the real reason for the bug
- fix the code, so the testcase PASSes
- commit both the fix and the testcase

This approach has some overhead, however it has advantages that are
really worth it:
- it forces you to think about the problem before you start coding
- very often I find that my first idea on how to fix a bug is wrong. An
example is my discussion with Lillian on IRC lately, where she and I had
several ideas how to fix the bug, and none was completely right. The
right fix first showed up when I hacked together some testcases
- it makes sure that nobody comes and fixes another bug which will
revert your fix. This would cause a regression which will be recognized
fast with Tromey's new regression checker or through manual regression
runs (like before a release).
- you have hard arguments when arguing about your fix ;-)
- it helps to build a complete testsuite for GNU Classpath which can be
used for compatibility checking.

Cheers,
/Roman

signature.asc
Description: Dies ist ein digital signierter Nachrichtenteil