classpath-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[cp-patches] FYI: Container fixlet


From: Roman Kennke
Subject: [cp-patches] FYI: Container fixlet
Date: Tue, 06 Dec 2005 16:25:26 +0000

Mark pointed out that my fix from

2005-11-17  Roman Kennke  <address@hidden>

        * java/awt/Container.java
        (Container): Added comment.
        (remove): Only call removeNotify if removed component is still
        showing.
        (paintComponents): Call paint() instead of super.paint().
        (AccessibleContainerHandler.AccessibleContainerHandler): Added
        comment.
        (LightweightDispatcher.acquireComponentForMouseEvent):
        Don't special case MOUSE_RELEASED events. They should be
        dispatched unmodified just as MOUSE_PRESSED.
        (LightweightDispatcher.handleEvent): Also clean up the pressCount
        after a MOUSE_


was not quite right. We actually should dispatch the MOUSE_RELEASE to the
same component that received the original MOUSE_PRESSED, otherwise
dragging is not working correctly, because the MOUSE_RELEASE will be
dispatched to an arbitrary component, but not the dragged component.
This is fixed by the attached patch:

2005-12-06  Roman Kennke  <address@hidden>

        PR classpath/25256
        * java/awt/Container.java
        (LightweightDispatcher.acquireComponentForMouseEvent): When we
        receive a MOUSE_RELEASED then dispatch it to the same component
        that received the original MOUSE_PRESSED. This is needed for
        correct dragging behaviour.


/Roman

Attachment: patch.diff
Description: Text Data


reply via email to

[Prev in Thread] Current Thread [Next in Thread]