Re: [cp-patches] FYI: Container fixlet

[Roman Kennke]

Hi Mark,

Am Dienstag, den 06.12.2005, 18:49 +0100 schrieb Mark Wielaard:
> Hi Roman,
> 
> On Tue, 2005-12-06 at 16:25 +0000, Roman Kennke wrote:
> > 2005-12-06  Roman Kennke  <address@hidden>
> > 
> >     PR classpath/25256
> >     * java/awt/Container.java
> >     (LightweightDispatcher.acquireComponentForMouseEvent): When we
> >     receive a MOUSE_RELEASED then dispatch it to the same component
> >     that received the original MOUSE_PRESSED. This is needed for
> >     correct dragging behaviour.
> > [...]
> > @@ -2157,12 +2157,18 @@
> >          break;
> >        }
> >  
> > -    if (me.getID() == MouseEvent.MOUSE_PRESSED && modifiers > 0
> > +    if (me.getID() == MouseEvent.MOUSE_PRESSED
> > +        && me.getID() == MouseEvent.MOUSE_PRESSED && modifiers > 0
> >          || me.getID() == MouseEvent.MOUSE_DRAGGED)
> >        {
> 
> Shouldn't that first line say MouseEvent.MOUSE_RELEASED now, and
> shouldn't the condition be an || ?
> 
>   if (me.getID() == MouseEvent.MOUSE_RELEASED
>       || (me.getID() == MouseEvent.MOUSE_PRESSED && modifiers > 0)
>       || me.getID() == MouseEvent.MOUSE_DRAGGED)

Of course you are right. I really shouldn't send patches at the end of a
long working day...

2005-12-06  Roman Kennke  <address@hidden>

        PR classpath/25256
        * java/awt/Container.java
        (LightweightDispatcher.acquireComponentForMouseEvent): Fixed
        the MOUSE_RELEASED flag and || conditional.

/Roman

patch.diff
Description: Text Data

signature.asc
Description: Dies ist ein digital signierter Nachrichtenteil