Re: [cp-patches] StAX parser fixes

[Mark Wielaard]

Hi Chris,

On Thu, 2005-12-15 at 14:30 +0000, Chris Burdess wrote:
> @@ -897,15 +982,15 @@
>      throws IOException, XMLStreamException
>    {
>      int c = read();
> -    if (c == -1)
> +    /*if (c == -1)
>        {
>          if (inputStack.size() > 1)
>            {
>              popInput();
>              return readCh();
>            }
> -        return '\uFFFF';
> -      }
> +        return (char) -1;
> +      }*/

Not being familiar with this code and the ChangeLog entry being a little
sparse on details makes it hard to say whether or not this part was
commented out deliberately. If it was then it is probably better to just
remove it completely. At least add a good comment saying why the
commented out code is there.

Thanks,

Mark

signature.asc
Description: This is a digitally signed message part