Re: [cp-patches] StAX parser fixes

[Chris Burdess]

Mark Wielaard wrote:
> On Thu, 2005-12-15 at 14:30 +0000, Chris Burdess wrote:
> > @@ -897,15 +982,15 @@
> >      throws IOException, XMLStreamException
> >    {
> >      int c = read();
> > -    if (c == -1)
> > +    /*if (c == -1)
> >        {
> >          if (inputStack.size() > 1)
> >            {
> >              popInput();
> >              return readCh();
> >            }
> > -        return '\uFFFF';
> > -      }
> > +        return (char) -1;
> > +      }*/
> 
> Not being familiar with this code and the ChangeLog entry being a little
> sparse on details makes it hard to say whether or not this part was
> commented out deliberately. If it was then it is probably better to just
> remove it completely. At least add a good comment saying why the
> commented out code is there.

Yes, it was deliberate and I've removed commented out code in the most
recent patch. I'll do a major code documentation job as soon as the main
architectural issues are ironed out (i.e. validation is complete).
-- 
Chris Burdess
  "They that can give up essential liberty to obtain a little safety
  deserve neither liberty nor safety." - Benjamin Franklin

pgpGQtSn5C7lo.pgp
Description: PGP signature