[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: java.util.ResourceBundle bug?

From: Bryce McKinlay
Subject: Re: java.util.ResourceBundle bug?
Date: Sat, 03 Nov 2001 17:29:08 +1300
User-agent: Mozilla/5.0 (X11; U; Linux ppc; en-US; rv:0.9.5) Gecko/20011016

[cc'ing classpath - see below]

Boehm, Hans wrote:

Hans> Unless I'm mistaken, the stopgap implementation of
Hans> java.util.ResourceBundle.getClassContext() in
Hans> is broken.

I agree.

Well spotted - this bug was causing libjava to be pretty much totally broken on PowerPC, and all this time I thought it was a miscompilation (no thanks to GCC not being able to compile libjava without -O on PowerPC).

Hans> -  elts[0] = java::lang::ClassLoader::getSystemClassLoader ();
Hans> +  elts[0] = &java::lang::Object::class$;

Based on comments in, I think the right patch is
to use:

   elts[0] = &class$;

(i.e., the ResourceBundle class.)
Feel free to check this in if you'd like to make the change.

I think the correct fix is to remove this method (ResourceBundle.getClassContext) and altogether. There is no reason to have a separate implementation of getClassContext() here, instead it should call the static implementation in VMSecurityManager. The problem is that VMSecurityManager is in java.lang and package-private, but I don't think it should be, since there are classes in other packages which need access to this functionality.

I think we should move it to and make it public. Same goes for java.lang.VMClassLoader. Does anyone disagree?



reply via email to

[Prev in Thread] Current Thread [Next in Thread]