Re: [PATCH] scripts: git commit message hook: prohibit use of "Signed-off-by

[Stefano Lattarini]

Jim Meyering wrote:
>
> I noticed a lot of Signed-off-by: lines in Stefano's series.
> This makes our no-S-o-b policy more apparent:
>
> >From 4f76f9b42ad71df40f1f714f2ecfb1e4b6cd7078 Mon Sep 17 00:00:00 2001
> From: Jim Meyering <address@hidden>
> Date: Thu, 30 Aug 2012 13:07:10 +0200
> Subject: [PATCH] scripts: git commit message hook: prohibit use of  
> "Signed-off-by:"
>
> * scripts/git-hooks/commit-msg: Reject a commit log message that
> contains "Signed-off-by:".
> ---
>  scripts/git-hooks/commit-msg | 3 +++
>  1 file changed, 3 insertions(+)
>
> diff --git a/scripts/git-hooks/commit-msg b/scripts/git-hooks/commit-msg
> index a5e4090..f867331 100755
> --- a/scripts/git-hooks/commit-msg
> +++ b/scripts/git-hooks/commit-msg
> @@ -125,6 +125,9 @@ sub check_msg($$)
>    $buf =~ m!https?://debbugs\.gnu\.org/(?:cgi/bugreport\.cgi\?bug=)?(\d+)!s
>      and return "use shorter http://bugs.gnu.org/$1";;;
>
> +  $buf =~ /^ *Signed-off-by:/i
> +    and return q(do not use "Signed-off-by:");
> +
>    return '';
>  }
>
Sigh, this will likely cause problems with my "ci" git alias ("commit -s"),
which I'm very finger-trained to use.  Couldn't the hook be instead enhanced
to strip "Signed-off-by:" lines?  Or better again, those "Signed-off-by:"
lines that refer to the author or the committer?

Regards,
  Stefano