[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] scripts: git commit message hook: prohibit use of "Signed-of
From: |
Stefano Lattarini |
Subject: |
Re: [PATCH] scripts: git commit message hook: prohibit use of "Signed-off-by |
Date: |
Thu, 30 Aug 2012 15:54:04 +0200 |
On 08/30/2012 03:36 PM, Jim Meyering wrote:
> Stefano Lattarini wrote:
>> Jim Meyering wrote:
>>>
>>> I noticed a lot of Signed-off-by: lines in Stefano's series.
>>> This makes our no-S-o-b policy more apparent:
> ...
>>> + $buf =~ /^ *Signed-off-by:/i
>>> + and return q(do not use "Signed-off-by:");
>>> +
>>> return '';
>>> }
>>>
>> Sigh, this will likely cause problems with my "ci" git alias ("commit -s"),
>> which I'm very finger-trained to use. Couldn't the hook be instead enhanced
>> to strip "Signed-off-by:" lines? Or better again, those "Signed-off-by:"
>> lines that refer to the author or the committer?
>
> I suggest you avoid using git commit's -s option.
> Instead, record your general preference in ~/.gitconfig and in
> any coreutils working directory do this (assuming that differs):
>
> git config format.signoff true
>
s/true/false/ I guess ...
> From then on, "git ci" will do what we want.
>
OK, I'll surely give it a try.
Thanks,
Stefano