coreutils
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] base32: A new program similar to base64


From: Jim Meyering
Subject: Re: [PATCH] base32: A new program similar to base64
Date: Tue, 1 Sep 2015 09:38:28 -0700

On Tue, Sep 1, 2015 at 6:46 AM, Pádraig Brady <address@hidden> wrote:
> A couple of related updates to base64 attached.

Nice work. The two base64 patches look fine; I note that
they'll be applied in the opposite order. It felt a little odd
that the log in the bug-fix patch makes a point of saying
it's preserving backwards compatibility, yet the one listed
first goes ahead and breaks that.

I skimmed the larger base32-adding patch and found no nit to pick.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]