Re: [PATCH] base32: A new program similar to base64

[Pádraig Brady]

On 01/09/15 23:37, Bernhard Voelker wrote:
> On 09/01/2015 03:41 PM, Pádraig Brady wrote:
>> diff --git a/src/base64.c b/src/base64.c
>> index ec3fe07..8cc23e4 100644
>> --- a/src/base64.c
>> +++ b/src/base64.c
> 
> Nice work!
> 
> Minor nits:
> 
>> @@ -59,8 +63,8 @@ usage (int status)
>>      {
>>        printf (_("\
>>  Usage: %s [OPTION]... [FILE]\n\
>> -Base64 encode or decode FILE, or standard input, to standard output.\n\
>> -"), program_name);
>> +Base%d encode or decode FILE, or standard input, to standard output.\n\
>> +"), program_name, BASE_TYPE);
>>  
>>        emit_stdin_note ();
>>        emit_mandatory_arg_note ();
>> @@ -74,13 +78,13 @@ Base64 encode or decode FILE, or standard input, to 
>> standard output.\n\
>>  "), stdout);
>>        fputs (HELP_OPTION_DESCRIPTION, stdout);
>>        fputs (VERSION_OPTION_DESCRIPTION, stdout);
>> -      fputs (_("\
>> +      printf (_("\
>>  \n\
>> -The data are encoded as described for the base64 alphabet in RFC 3548.\n\
>> +The data are encoded as described for the base%d alphabet in RFC 4648.\n\
>>  When decoding, the input may contain newlines in addition to the bytes of\n\
>> -the formal base64 alphabet.  Use --ignore-garbage to attempt to recover\n\
>> +the formal base%d alphabet.  Use --ignore-garbage to attempt to recover\n\
>>  from any other non-alphabet bytes in the encoded stream.\n"),
>> -             stdout);
>> +              BASE_TYPE, BASE_TYPE);
>>        emit_ancillary_info (PROGRAM_NAME);
>>      }
>>  
> 
> I think it may be unclear for the translators what this is about.
> What about using %s and PROGRAM_NAME instead?

+1

> Another question:
> shouldn't base32 also be run in tests/misc/tty-eof.pl?

+1
We should add numfmt too.

> Finally, the man page speaks about the online manual at
>   http://www.gnu.org/software/coreutils/base32
> I guess the redirection has to be set up manually (in addition to
> uploading the new manual)?

You don't miss much!
I could bluff that I was going to do that, but I did forget :)
I'll look into some automation to check that.

thanks!
Pádraig.