[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: numfmt: minor improvements to --field parsing
From: |
Pádraig Brady |
Subject: |
Re: numfmt: minor improvements to --field parsing |
Date: |
Thu, 10 Sep 2015 15:53:38 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 |
On 10/09/15 15:19, Assaf Gordon wrote:
> Hello,
>
> On Wed, Sep 09, 2015 at 11:14:20AM +0100, Pádraig Brady wrote:
>> One tweak I would add is to add getlimits to the test
>> and s/9918446744073709551616/SIZE_MAX/
>>
>> Otherwise it looks great.
>> Pleas push after that tweak.
>
> Updated version attached.
> Just to verify this is what you meant before pushing, the test is now:
> ---
> ['field-range-err-13','--field '.$limits->{SIZE_OFLOW}.',22 --to=si 10',
> {EXIT=>1}, {ERR=>"$prog: field number " .
> "'".$limits->{SIZE_OFLOW}."' is too large\n$try"}],
> ---
Usually you would use SIZE_OFLOW in this context,
but here SIZE_MAX is used internally to represent an open ended range,
thus is not allowed as input. Therefore SIZE_MAX is more correct here.
thanks,
Pádraig.