[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Gnustep-cvs] r29010 - in /libs/gui/trunk: ChangeLog Headers/AppKit/

From: Fred Kiefer
Subject: Re: [Gnustep-cvs] r29010 - in /libs/gui/trunk: ChangeLog Headers/AppKit/NSCell.h Source/NSActionCell.m Source/NSCell.m
Date: Tue, 17 Nov 2009 09:11:58 +0100
User-agent: Thunderbird (X11/20090817)

Wolfgang Lux schrieb:
> Fred Kiefer wrote:
> Yes, but the problem of this code is that the cell's border is not redrawn
> when necessary. E.g., in the NSForm test of GSTest just start editing the
> text field at the top of the window and then resize the window. The field
> editor is redrawn, but the border is not. In fact, this is the reason why
> I had commented out the quoted code locally a while ago (and then forgotten
> about it). As far as I understand the comment in NSControl, the idea of
> this "fix" was to avoid drawing the cell's contents twice, once from the
> cell and once from the editor. However, it would look much more natural to
> me to address this problem in NSCell's -drawWithFrame:inView: method and
> only draw the cell's border if the cell is edited. I've attached the
> corresponding patches to NSCell and NSControl below. Am I missing something
> obvious here (apart from the fact that we probably should not even draw the
> background of the cell when it is edited and hence will need an additional
> method)?

I cannot test your patch, as the flicker is already gone for me :-)
But from code inspection I would say that your change looks fine to me.
Feel free to go ahead and commit.
The code you are removing was written by Nicola if I remember correctly.
 Perhaps he has something to say on this?


reply via email to

[Prev in Thread] Current Thread [Next in Thread]