discuss-gnustep
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: libobjc2 still failing tests


From: Andreas Fink
Subject: Re: libobjc2 still failing tests
Date: Fri, 25 Jan 2019 17:46:07 +0100

 17/162 Test  #17: AssociatedObject ..................................   Passed 
   0.00 sec
        Start  18: AssociatedObject_optimised
 18/162 Test  #18: AssociatedObject_optimised 
........................***Exception: Other  0.00 sec
        Start  19: AssociatedObject_legacy
 19/162 Test  #19: AssociatedObject_legacy ...........................   Passed 
   0.00 sec
        Start  20: AssociatedObject_legacy_optimised
 20/162 Test  #20: AssociatedObject_legacy_optimised 
.................***Exception: Other  0.00 sec

this still fails with clang-8


> On 25 Jan 2019, at 17:41, David Chisnall <address@hidden> wrote:
> 
> On 25/01/2019 14:01, Andreas Fink wrote:
>> I found out what makes it break.
>> The cmake option   -DCMAKE_BUILD_TYPE=RelWithDebInfo
> 
> Thanks.  There was a bug in the log2 calculation for storing the ivar offsets 
> that worked at O0 because of wrapping behaviour when we truncated the value 
> to 32-bit, but triggered undefined behaviour that allowed the optimiser to 
> remove a check.  The tests are now all passing for me in release and debug 
> configurations.
> 
> David





reply via email to

[Prev in Thread] Current Thread [Next in Thread]