--- Begin Message ---
Subject: |
[PATCH 0/1] gnu: Add emacs-browse-at-remote. |
Date: |
Thu, 17 Aug 2017 21:00:37 +0300 |
Hello Guix,
I tried to ask an upstream to provide a release tarball, but no answer still.
https://github.com/rmuslimov/browse-at-remote/issues/40
Is string-join and dired-current-directory warning important?
--8<---------------cut here---------------start------------->8---
In end of data:
browse-at-remote.el:363:1:Warning: the following functions are not known to be
defined: string-join, dired-current-directory
--8<---------------cut here---------------end--------------->8---
string-join defined in
/gnu/store/…-emacs-25.2/share/emacs/25.2/lisp/emacs-lisp/subr-x.el.gz
dired-current-directory defined in
/gnu/store/…-emacs-25.2/share/emacs/25.2/lisp/dired.el.gz
Thanks!
Oleg Pykhalov (1):
gnu: Add emacs-browse-at-remote.
gnu/packages/emacs.scm | 51 ++++++++++++++++++++++++++++++++++++++++++++++++++
1 file changed, 51 insertions(+)
--
2.14.1
--- End Message ---
--- Begin Message ---
Subject: |
Re: [bug#28126] [PATCH 1/1] gnu: Add emacs-browse-at-remote. |
Date: |
Sat, 02 Sep 2017 22:43:20 +0300 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/25.2 (gnu/linux) |
Oleg Pykhalov (2017-08-17 21:20 +0300) wrote:
>>From 32a917cb337dbb25010d687f21b3d305eb01a852 Mon Sep 17 00:00:00 2001
> From: Oleg Pykhalov <address@hidden>
> Date: Thu, 17 Aug 2017 20:35:43 +0300
> Subject: [PATCH 1/1] gnu: Add emacs-browse-at-remote.
>
> * gnu/packages/emacs.scm (emacs-browse-at-remote): New variable.
> ---
> gnu/packages/emacs.scm | 51
> ++++++++++++++++++++++++++++++++++++++++++++++++++
> 1 file changed, 51 insertions(+)
>
> diff --git a/gnu/packages/emacs.scm b/gnu/packages/emacs.scm
> index 1728b5b92..faa131812 100644
> --- a/gnu/packages/emacs.scm
> +++ b/gnu/packages/emacs.scm
> @@ -5380,3 +5380,54 @@ enables you to easily define search engines, bind them
> to keybindings, and
> query them from the comfort of your editor.")
> (home-page "https://github.com/hrs/engine-mode")
> (license license:gpl3+)))
> +
> +(define-public emacs-browse-at-remote
> + (let ((commit "b5cff7971ca8bbb966e3acd9b7e5c4c007f94215")
> + (revision "1"))
> + (package
> + (name "emacs-browse-at-remote")
> + (version (string-append "0.9.0-" revision "."
> + (string-take commit 7)))
> + (source (origin
> + (method git-fetch)
> + (uri (git-reference
> + (url
> "https://github.com/rmuslimov/browse-at-remote.git")
> + (commit commit)))
> + (file-name (string-append name "-" version "-checkout"))
> + (sha256
> + (base32
> + "16ms9703m15dfxg6ap4mdw7msf8z5rzsdhba51dwivfpjxg7n52c"))))
> + (build-system emacs-build-system)
> + (propagated-inputs
> + `(("emacs-f" ,emacs-f)
> + ("emacs-s" ,emacs-s)
> + ("emacs-dash" ,emacs-dash)))
This package does not require "dash", so I removed it from here...
> + (arguments
> + `(#:phases
> + (modify-phases %standard-phases
> + (add-before 'install 'check
> + (lambda* (#:key inputs #:allow-other-keys)
> + (zero? (system* "emacs" "--batch" "-L" "."
> + "-L" (string-append
> + (assoc-ref inputs "emacs-f")
> + "/share/emacs/site-lisp/guix.d/f-"
> + ,(package-version emacs-f))
> + "-L" (string-append
> + (assoc-ref inputs "emacs-s")
> + "/share/emacs/site-lisp/guix.d/s-"
> + ,(package-version emacs-s))
> + "-L" (string-append
> + (assoc-ref inputs "emacs-dash")
> + "/share/emacs/site-lisp/guix.d/dash-"
> + ,(package-version emacs-dash))
... and here.
> + "-l" "test/api-basic-test.el"
> + "-f" "ert-run-tests-batch-and-exit")))))))
Wow, you even made the phase to run tests! To be honest, I wouldn't
bother about it :-) (but don't tell it anyone)
> + (home-page "https://github.com/rmuslimov/browse-at-remote")
> + (synopsis
> + "Open github/gitlab/bitbucket/stash page from Emacs")
> + (description
> + "Easily open target page on github/gitlab (or bitbucket) from Emacs by
> +calling @code{browse-at-remote} function. Support dired buffers and opens
> +them in tree mode at destination.
> +")
> + (license license:gpl3+))))
I have adjusted the description a bit and committed:
http://git.savannah.gnu.org/cgit/guix.git/commit/?id=eaf4ba6ef3319ca6b4eeb5cf5021768f7b438934
Thank you!
--
Alex
--- End Message ---