[debbugs-tracker] bug#28126: closed ([PATCH 0/1] gnu: Add emacs-browse-at-remote.)

[GNU bug Tracking System]

Your message dated Mon, 04 Sep 2017 22:49:57 +0300
with message-id <address@hidden>
and subject line Re: [bug#28126] [PATCH 1/1] gnu: Add emacs-browse-at-remote.
has caused the debbugs.gnu.org bug report #28126,
regarding [PATCH 0/1] gnu: Add emacs-browse-at-remote.
to be marked as done.

(If you believe you have received this mail in error, please contact
address@hidden)


-- 
28126: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=28126
GNU Bug Tracking System
Contact address@hidden with problems
> --- Begin Message ---
>
>
>
> Subject: 
>
> [PATCH 0/1] gnu: Add emacs-browse-at-remote.
>
>
>
>
> Date: 
>
> Thu, 17 Aug 2017 21:00:37 +0300
>
>
>
>
> Hello Guix,
>
> I tried to ask an upstream to provide a release tarball, but no answer still.
> https://github.com/rmuslimov/browse-at-remote/issues/40
>
> Is string-join and dired-current-directory warning important?
>
> --8<---------------cut here---------------start------------->8---
> In end of data:
> browse-at-remote.el:363:1:Warning: the following functions are not known to be
>     defined: string-join, dired-current-directory
> --8<---------------cut here---------------end--------------->8---
>
> string-join defined in
> /gnu/store/…-emacs-25.2/share/emacs/25.2/lisp/emacs-lisp/subr-x.el.gz
>
> dired-current-directory defined in
> /gnu/store/…-emacs-25.2/share/emacs/25.2/lisp/dired.el.gz
>
> Thanks!
>
> Oleg Pykhalov (1):
>   gnu: Add emacs-browse-at-remote.
>
>  gnu/packages/emacs.scm | 51 ++++++++++++++++++++++++++++++++++++++++++++++++++
>  1 file changed, 51 insertions(+)
>
> -- 
> 2.14.1
>
>
>
> --- End Message ---
> --- Begin Message ---
>
>
>
> Subject: 
>
> Re: [bug#28126] [PATCH 1/1] gnu: Add emacs-browse-at-remote.
>
>
>
>
> Date: 
>
> Mon, 04 Sep 2017 22:49:57 +0300
>
>
>
>
> User-agent: 
>
> Gnus/5.13 (Gnus v5.13) Emacs/25.2 (gnu/linux)
>
>
>
>
> Oleg Pykhalov (2017-09-04 11:39 +0300) wrote:
>
> > Hello Alex,
> >
> > Alex Kost <address@hidden> writes:
> >
> > …
> >> This package does not require "dash", so I removed it from here...
> >
> > It requires according to build logs, 
> > http://hydra.gnu.org/build/2253531/log/raw
>
> Oops, indeed.  I thought I tested the modified version of your patch,
> but apparently I built your original patch, that's why the build was
> successful for me.  Thank you for pointing!
>
> At first I was confused, as "browse-at-remote" does not require "dash".
> But then I realized where this "dash" dependency comes from:
> "browse-at-remote" requires "f" and "f" requires "dash".
>
> So "dash" is not needed to be in 'propagated-inputs' (as it is
> propagated by "f").  As for the tests, I realized that this package is
> intended to use 'ert-runner' to run the tests, so using it simplifies
> the 'check' phase:
>
>   
> http://git.savannah.gnu.org/cgit/guix.git/commit/?id=8505d34829b99744a36d72dd583768f1e49210a6
>
> Hopefully, it will be built successfully this time :-)
>
> -- 
> Alex
>
>
>
> --- End Message ---