emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: setq-default docstring fix


From: Juri Linkov
Subject: Re: setq-default docstring fix
Date: Tue, 04 May 2004 21:29:41 +0300
User-agent: Gnus/5.110002 (No Gnus v0.2) Emacs/21.3.50 (gnu/linux)

Stefan Monnier <address@hidden> writes:
>> The docstring for setq-default mentions an argument named VAR, but it
>> is really named SYMBOL.  Could someone please install this?
>
> I'd rather fix the arglist to use `var'.

The Emacs Lisp reference manual describes it as `symbol'.  But then it
uses `form' instead of `value' for the second argument.  I don't have
an opinion about the name, I only want to point out that it should be
consistently used in all documentation.

BTW, I suggest to change the argument names of `rassq' and `rassoc' too:

Index: emacs/src/fns.c
===================================================================
RCS file: /cvsroot/emacs/emacs/src/fns.c,v
retrieving revision 1.362
diff -u -r1.362 fns.c
--- emacs/src/fns.c     26 Apr 2004 21:44:22 -0000      1.362
+++ emacs/src/fns.c     1 May 2004 04:04:32 -0000
@@ -1603,10 +1603,10 @@
 }
 
 DEFUN ("rassq", Frassq, Srassq, 2, 2, 0,
-       doc: /* Return non-nil if KEY is `eq' to the cdr of an element of LIST.
-The value is actually the first element of LIST whose cdr is KEY.  */)
-     (key, list)
-     register Lisp_Object key;
+       doc: /* Return non-nil if VALUE is `eq' to the cdr of an element of 
LIST.
+The value is actually the first element of LIST whose cdr is VALUE.  */)
+     (value, list)
+     register Lisp_Object value;
      Lisp_Object list;
 {
   Lisp_Object result;
@@ -1615,19 +1615,19 @@
     {
       if (!CONSP (list)
          || (CONSP (XCAR (list))
-             && EQ (XCDR (XCAR (list)), key)))
+             && EQ (XCDR (XCAR (list)), value)))
        break;
 
       list = XCDR (list);
       if (!CONSP (list)
          || (CONSP (XCAR (list))
-             && EQ (XCDR (XCAR (list)), key)))
+             && EQ (XCDR (XCAR (list)), value)))
        break;
 
       list = XCDR (list);
       if (!CONSP (list)
          || (CONSP (XCAR (list))
-             && EQ (XCDR (XCAR (list)), key)))
+             && EQ (XCDR (XCAR (list)), value)))
        break;
 
       list = XCDR (list);
@@ -1645,10 +1645,10 @@
 }
 
 DEFUN ("rassoc", Frassoc, Srassoc, 2, 2, 0,
-       doc: /* Return non-nil if KEY is `equal' to the cdr of an element of 
LIST.
-The value is actually the first element of LIST whose cdr equals KEY.  */)
-     (key, list)
-     Lisp_Object key, list;
+       doc: /* Return non-nil if VALUE is `equal' to the cdr of an element of 
LIST.
+The value is actually the first element of LIST whose cdr equals VALUE.  */)
+     (value, list)
+     Lisp_Object value, list;
 {
   Lisp_Object result, cdr;
 
@@ -1657,21 +1657,21 @@
       if (!CONSP (list)
          || (CONSP (XCAR (list))
              && (cdr = XCDR (XCAR (list)),
-                 EQ (cdr, key) || !NILP (Fequal (cdr, key)))))
+                 EQ (cdr, value) || !NILP (Fequal (cdr, value)))))
        break;
 
       list = XCDR (list);
       if (!CONSP (list)
          || (CONSP (XCAR (list))
              && (cdr = XCDR (XCAR (list)),
-                 EQ (cdr, key) || !NILP (Fequal (cdr, key)))))
+                 EQ (cdr, value) || !NILP (Fequal (cdr, value)))))
        break;
 
       list = XCDR (list);
       if (!CONSP (list)
          || (CONSP (XCAR (list))
              && (cdr = XCDR (XCAR (list)),
-                 EQ (cdr, key) || !NILP (Fequal (cdr, key)))))
+                 EQ (cdr, value) || !NILP (Fequal (cdr, value)))))
        break;
 
       list = XCDR (list);

-- 
Juri Linkov
http://www.jurta.org/emacs/





reply via email to

[Prev in Thread] Current Thread [Next in Thread]