Re: address@hidden: skeleton bug]

[Kenichi Handa]

In article <address@hidden>, Richard Stallman <address@hidden> writes:

> ------- Start of forwarded message -------
> To: address@hidden
> From: address@hidden
> Date: Fri, 17 Aug 2007 14:36:29 +0300
> Subject: skeleton bug

[...]
>   The skeleton looks like this : 

> (define-skeleton test-skeleton
>   "This is a small doc for the skeleton."
>   ""                                    ;no prompt
> "<ul>"
>   \n > "<li>"
>   \n > _
>   \n > -1 "</li>"
>   \n > "</ul>"
>   \n)

>   but it does not work ! The error I get follows:

> Debugger entered--Lisp error: (error "Lisp nesting exceeds 
> `max-lisp-eval-depth'")

I found that this is because of the following incompatible
change in emacs-unicode-2.

Emacs-22: (char-or-string-p -1) => t
Emacs-23: (char-or-string-p -1) => nil

According to the function name, I think it should return nil
on -1.

Which do you think is better?

(1) Revert the change of char-or-string-p.

(2) Keep char-or-string-p as is in emacs-unicode-2,
    make a new function integer-or-string-p, and check all
    occurrences of char-or-string-p in *.el files.

FYI, char-or-string-p is used only in 8 places.

---
Kenichi Handa
address@hidden