[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: address@hidden: skeleton bug]
From: |
Kenichi Handa |
Subject: |
Re: address@hidden: skeleton bug] |
Date: |
Fri, 07 Sep 2007 11:33:20 +0900 |
User-agent: |
SEMI/1.14.3 (Ushinoya) FLIM/1.14.2 (Yagi-Nishiguchi) APEL/10.2 Emacs/23.0.0 (i686-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) |
In article <address@hidden>, Stefan Monnier <address@hidden> writes:
> > I found that this is because of the following incompatible
> > change in emacs-unicode-2.
> > Emacs-22: (char-or-string-p -1) => t
> > Emacs-23: (char-or-string-p -1) => nil
> > According to the function name, I think it should return nil
> > on -1.
> > Which do you think is better?
> > (1) Revert the change of char-or-string-p.
> > (2) Keep char-or-string-p as is in emacs-unicode-2,
> > make a new function integer-or-string-p, and check all
> > occurrences of char-or-string-p in *.el files.
> > I think we should keep the changed behavior of char-or-string-p,
> > which fits with its name, and check all 8 callers.
> Agreed,
Ok. It was only skeleton.el that has a problem, and I fixed
it. I didn't create integer-or-string-p because it seems
that the function is not that useful. In skeleton.el, I
simply used the combination of integerp and stringp.
---
Kenichi Handa
address@hidden