emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Uninformative comment in files.el


From: Vinicius Jose Latorre
Subject: Re: Uninformative comment in files.el
Date: Tue, 11 Dec 2007 23:22:35 -0300
User-agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8.1.11) Gecko/20071128 SeaMonkey/1.1.7

martin rudalics wrote:
Could whoever installed the following change:

2007-12-10 Yoni Rabkin Katzenell <address@hidden> (tiny change)
   * file.el (revert-buffer): Eliminate overlays and the mark.

replace the comment "Reset the mark and remove all overlays" which just
paraphrases the code, with a comment that actually explains why we
want/need to do that?


This is not explained in etc/TODO file.

The patch refers to this line in etc/TODO file:

   ** revert-buffer should eliminate overlays and the mark.


Does anyone know why this is necessary?

I'm afraid the patch installed is overly simplistic.  You can find out
more by looking at the thread starting with

http://lists.gnu.org/archive/html/emacs-devel/2005-11/msg01346.html

For the moment I'd strongly propose to revert the change and study the
problem in more depth.

Ok, I've read the thread.  Indeed, the problem is not so simple.

I've just undone the patch in CVS trunk.





reply via email to

[Prev in Thread] Current Thread [Next in Thread]