[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: patch to hilight-chg not in emacs 22.1
From: |
Stefan Monnier |
Subject: |
Re: patch to hilight-chg not in emacs 22.1 |
Date: |
Wed, 19 Mar 2008 12:20:13 -0400 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/23.0.60 (gnu/linux) |
>> In what way are those problems different if the command is named
>> "highlight-changes-toggle-visibility" and implemented without
>> define-minor-mode?
> Yes, I agree it's the same thing in code. But I still think that people
> will find it confusing.
I'm pretty sure we can find a name that makes things clear.
E.g. rename highlight-changes-toggle-visibility to
highlight-changes-recording-only-mode (and reverse its meaning)?
> Originally, the highlight-change-mode function had the ability to also set
> active and passive states (when enabling the mode) and RMS thought it would
> be more consistent to have the function purely toggle the mode on or off.
> My reaction to having two related modes was that it would be confusing but
> I'm not really averse to it.
Make sure the docstring explains that one of the two minor-modes is
a sub-mode of the other.
Stefan
Re: patch to hilight-chg not in emacs 22.1, martin rudalics, 2008/03/18