[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Reviewing changes
From: |
Eli Zaretskii |
Subject: |
Re: Reviewing changes |
Date: |
Thu, 20 Nov 2008 22:19:33 +0200 |
> From: Stefan Monnier <address@hidden>
> Cc: address@hidden, address@hidden, address@hidden
> Date: Thu, 20 Nov 2008 09:30:25 -0500
>
> >> > If there's no agreement to have a review process, I can simply ignore
> >> > your review.
> >> Of course. Would that be a problem?
> > It makes the whole review process unreliable and inefficient.
>
> I don't follow you.
I really don't understand why. It's not like we are inventing some
new practices here. Code reviews are used in almost any organization
that develops software. Books are written on how to do that, and none
of those I've read recommend what is being suggested here as "good,
though not perfect".
IMO, if we cannot do it well, it isn't worth doing.
> We already have code reviews, just rarely so.
No, we don't. What we have is random (and very rare) comments, and no
mechanism to resolve disagreements when they happen.
- Re: Reviewing changes, (continued)
- Re: Reviewing changes, Stephen J. Turnbull, 2008/11/19
- Re: Reviewing changes, Karl Fogel, 2008/11/20
- Re: Reviewing changes, Stephen J. Turnbull, 2008/11/20
- Re: Reviewing changes, Stefan Monnier, 2008/11/19
- Re: Reviewing changes, Eli Zaretskii, 2008/11/19
- Re: Reviewing changes, Karl Fogel, 2008/11/20
- Re: Reviewing changes, Stefan Monnier, 2008/11/20
- Re: Reviewing changes,
Eli Zaretskii <=
- Re: Reviewing changes, Stefan Monnier, 2008/11/20
- Re: Reviewing changes, mail, 2008/11/20
- Re: Reviewing changes, Eli Zaretskii, 2008/11/21
- Re: Reviewing changes, Stefan Monnier, 2008/11/21
- Re: Reviewing changes, Eli Zaretskii, 2008/11/21
- Re: Reviewing changes, Stefan Monnier, 2008/11/21
- Re: Reviewing changes, Yavor Doganov, 2008/11/20
- Re: Reviewing changes, Stefan Monnier, 2008/11/20
Re: [Emacs-diffs] Changes to emacs/lisp/bookmark.el,v, Miles Bader, 2008/11/20