[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Bell
From: |
Juri Linkov |
Subject: |
Re: Bell |
Date: |
Tue, 30 Mar 2010 19:16:51 +0300 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (x86_64-pc-linux-gnu) |
> Currently in most cases a flashing screen is accompanied
> with an error message. I think it's a bug when there is
> no error message displayed. For instance, typing C-b or M-v
> at the beginning of the buffer displays "Beginning of buffer",
> but typing C-p doesn't display this error message. I think
> it is a bug that should be fixed with this patch:
Actually, `ding' with the error message deactivates the active region.
Better to use `signal' that doesn't deactivate the region:
=== modified file 'lisp/simple.el'
--- lisp/simple.el 2010-03-05 12:01:10 +0000
+++ lisp/simple.el 2010-03-20 23:57:09 +0000
@@ -4105,9 +4115,10 @@ (defun next-line (&optional arg try-vscr
(insert (if use-hard-newlines hard-newline "\n")))
(line-move arg nil nil try-vscroll))
(if (called-interactively-p 'interactive)
- (condition-case nil
+ (condition-case err
(line-move arg nil nil try-vscroll)
- ((beginning-of-buffer end-of-buffer) (ding)))
+ ((beginning-of-buffer end-of-buffer)
+ (signal (car err) nil)))
(line-move arg nil nil try-vscroll)))
nil)
@@ -4135,9 +4146,10 @@ (defun previous-line (&optional arg try-
(interactive "^p\np")
(or arg (setq arg 1))
(if (called-interactively-p 'interactive)
- (condition-case nil
+ (condition-case err
(line-move (- arg) nil nil try-vscroll)
- ((beginning-of-buffer end-of-buffer) (ding)))
+ ((beginning-of-buffer end-of-buffer)
+ (signal (car err) nil)))
(line-move (- arg) nil nil try-vscroll))
nil)
--
Juri Linkov
http://www.jurta.org/emacs/
- Re: AW: delete-selection-mode, (continued)
- Re: AW: delete-selection-mode, Miles Bader, 2010/03/19
- Bell (was: delete-selection-mode), Juri Linkov, 2010/03/19
- RE: Bell (was: delete-selection-mode), Drew Adams, 2010/03/19
- Re: Bell, Stefan Monnier, 2010/03/20
- Re: Bell, Miles Bader, 2010/03/20
- RE: Bell, Drew Adams, 2010/03/20
- Re: Bell, Juri Linkov, 2010/03/20
- Re: Bell, Lennart Borgman, 2010/03/20
- Re: Bell, Juri Linkov, 2010/03/21
- Re: Bell, Stefan Monnier, 2010/03/21
- Re: Bell,
Juri Linkov <=
- Re: Bell, Stefan Monnier, 2010/03/30
- Re: Bell, Juri Linkov, 2010/03/30
- Re: Bell, Stefan Monnier, 2010/03/30
- Re: Bell, Eli Zaretskii, 2010/03/31
- Re: Bell, Stefan Monnier, 2010/03/21
- RE: Bell, Drew Adams, 2010/03/22
- Re: Bell, Juri Linkov, 2010/03/20
- Re: AW: delete-selection-mode, David Kastrup, 2010/03/17
- RE: AW: delete-selection-mode, Drew Adams, 2010/03/17
- Re: AW: delete-selection-mode, Miles Bader, 2010/03/17