[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: The unwarranted scrolling assumption
From: |
Lennart Borgman |
Subject: |
Re: The unwarranted scrolling assumption |
Date: |
Fri, 18 Jun 2010 23:25:21 +0200 |
On Fri, Jun 18, 2010 at 9:00 PM, Eli Zaretskii <address@hidden> wrote:
>> From: Lennart Borgman <address@hidden>
>> Date: Fri, 18 Jun 2010 19:31:30 +0200
>> Cc: address@hidden
>>
>> + if ((w->current_matrix->begv != b->begv) || (w->current_matrix->zv !=
>> b->zv))
>> + b->clip_changed = 1;
>
> You cannot safely use w->current_matrix if w->window_end_valid is nil.
So you say that w->current_matrix->begv is not valid unless
window_end_valid is non-nil.
All the above test does is comparing the current clipping with that
recorded in w->current_matrix->begv/zv. In that case we must set
clip_changed to 1.
Are you saying that w->current_matrix->begv/zv is set before the
redisplay is finished? (I do not have the code here so I can not check
at the moment.)
If you are saying that then what you are saying above seems correct to
me. But on the other hand then I think what you said before about that
the redisplay engine had enough information for setting clip_changed
is false.
Can you explain more exactly how you are thinking?
> And if you add that test, you will end up with exactly the same code
> that was there originally.
>
> IOW, we still need to find out why reconsider_clip_changes fails to
> reset the clip_changed flag.
>
>
- Re: The unwarranted scrolling assumption, (continued)
- Re: The unwarranted scrolling assumption, Eli Zaretskii, 2010/06/18
- Re: The unwarranted scrolling assumption, Lennart Borgman, 2010/06/18
- Re: The unwarranted scrolling assumption, Eli Zaretskii, 2010/06/18
- Re: The unwarranted scrolling assumption, Lennart Borgman, 2010/06/18
- Re: The unwarranted scrolling assumption, Eli Zaretskii, 2010/06/18
- Re: The unwarranted scrolling assumption, Lennart Borgman, 2010/06/18
- Re: The unwarranted scrolling assumption, Eli Zaretskii, 2010/06/18
- Re: The unwarranted scrolling assumption, Lennart Borgman, 2010/06/18
- Re: The unwarranted scrolling assumption, Lennart Borgman, 2010/06/18
- Re: The unwarranted scrolling assumption, Eli Zaretskii, 2010/06/18
- Re: The unwarranted scrolling assumption,
Lennart Borgman <=
- Re: The unwarranted scrolling assumption, Lennart Borgman, 2010/06/18
- Re: The unwarranted scrolling assumption, Eli Zaretskii, 2010/06/19
- Re: The unwarranted scrolling assumption, Lennart Borgman, 2010/06/19
- Re: The unwarranted scrolling assumption, Eli Zaretskii, 2010/06/19
- Re: The unwarranted scrolling assumption, Lennart Borgman, 2010/06/19
- Re: The unwarranted scrolling assumption, Stefan Monnier, 2010/06/18
- Re: The unwarranted scrolling assumption, Lennart Borgman, 2010/06/18
- Re: The unwarranted scrolling assumption, Lennart Borgman, 2010/06/18
- Re: The unwarranted scrolling assumption, Lennart Borgman, 2010/06/17
- Re: The unwarranted scrolling assumption, Lennart Borgman, 2010/06/17