[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Emacs core TLS support

From: Ted Zlatanov
Subject: Re: Emacs core TLS support
Date: Mon, 27 Sep 2010 09:56:45 -0500
User-agent: Gnus/5.110011 (No Gnus v0.11) Emacs/24.0.50 (gnu/linux)

On Mon, 27 Sep 2010 16:40:09 +0200 Lars Magne Ingebrigtsen <address@hidden> 

LMI> Lars Magne Ingebrigtsen <address@hidden> writes:
>> If I return Qt when gnutls_handshake() returns zero, then I get the
>> Gmail IMAP greeting, which I think it works.
>> I'll clean it up and see whether that really fixed this...

LMI> I've checked in the changes, since it works a bit better now than
LMI> before.  Previously, it would try to do the handshake in a loop after
LMI> completing it, and that obviously doesn't work.

Hmm, GNUTLS_E_SUCCESS is 0 by definition.  But you say in your patch:

-  if (GNUTLS_E_SUCCESS == ret)
+  if (GNUTLS_E_SUCCESS == ret || ret == 0)
     /* here we're finally done.  */
+    return Qt;
   return gnutls_make_error (ret);

gnutls_make_error returns Qt when the error is GNUTLS_E_SUCCESS.  So
none of this should be necessary.  Similarly the change to gnutls.el:

-      (while (and (not (gnutls-error-fatalp ret))
+      (while (and (not (eq ret t))
+                 (not (gnutls-error-fatalp ret))

If you do (gnutls-error-fatalp t) you'll get nil, so again that
shouldn't have been necessary.  Am I missing something?


reply via email to

[Prev in Thread] Current Thread [Next in Thread]