[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: New function: vc-ediff

From: Christoph Scholtes
Subject: Re: New function: vc-ediff
Date: Mon, 28 Mar 2011 20:42:42 -0600
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (windows-nt)

Stefan Monnier <address@hidden> writes:

>> address@hidden vc-ediff
>> +The function @code{vc-ediff} works similar to @code{vc-diff} and
>> +provides a way to visually compare two revisions of a file an Ediff
>                                                             ^^^
>                                                             in?

Yes. Fixed.

> No need to give any detail about a new function's purpose, just "New
> function" is enough: the source code should explain the purpose (either
> self-evidently or via comments&docstrings).
> Also, remove the empty lines to make it clear that those three file-changes
> go together.

OK. Fixed also.

> Problem with this code is that you depend on ediff-revision to get
> the revision arguments.  E.g. this doesn't provide completion.
> IOW we should use more of vc-diff's code here.

It was my intention to reuse the code that ediff-revision already
provides to get the revision arguments. I am not sure I understand what
you mean by "does not provide completion".

Do you mean vc-diff's code to get the revision arguments?


reply via email to

[Prev in Thread] Current Thread [Next in Thread]