Re: ReRe: [Freepooma-devel] <pooma>/src/Particles/InterpolatorCIC.h

[Roman Krylov]

Hi all.
Wholly agree with Richard and John !
And I am not proposing to pollute the code with workarounds nor fork a 
branch with any dirt,
I merely stated the problem.
Surely it should be done in more sophisticated way than putting "if()"s 
everywhere, but...
InterpolatorCIC is 'insisting' on |intgl|>1 many times the same way, is 
it good?
if no, perhaps some refactoring should be done on that code.

Am I understanding right the issue? :)

Thanks.
Roman.

John H. Hall wrote:

> Roman:
> Richard is right in that one should create a specialized object rather 
> than loading up the code base with a bunch of conditionals. I don't 
> have time to figure out what should be specialized in this case, but 
> from a software engineering point of view that is the way to go. 
> Maintenance over the entire software life cycle is the operative 
> principal here and specialization (and therefore encapsulation of 
> conditional cases is superior to explicit conditionals that end up 
> popping up everywhere breaking encapsulation).
> John Hall
>
> On Mar 31, 2005, at 10:43 AM, Roman Krylov wrote:
>
> > Hi.
> >
> > > But if you only have one patch, you can as well use 1 internal 
> > > guard, no?  I only can imagine DomainLayout being special here, but 
> > > would need
> > > to check that.  I don't think specializing like above for layout global
> > > size is a good idea from a SW engineering position.
> >
> >
> > No, pooma sets all guardLayers width to 0 when only 1 patch is used, 
> > even if one forces it to be 1 or higher !
> > That was the problem for my program using CIC where I used 1 patch.
> > Now with InterpolatorCIC.h I posted earlier it works.
> > Certainly, I could use more patches earlier as in examples/PIC2d, but 
> > I did not understand that time what was the problem,
> > now I know :)
> > But,,, does anyone need internal guardlayer at all with only 1 patch? 
> > I think no. Am I wrong? :)
> > Thanks.
> > Roman.
> >
> >
> > _______________________________________________
> > Freepooma-devel mailing list
> > address@hidden
> > http://lists.nongnu.org/mailman/listinfo/freepooma-devel
>
>
>
>
> _______________________________________________
> Freepooma-devel mailing list
> address@hidden
> http://lists.nongnu.org/mailman/listinfo/freepooma-devel