[ft-devel] suspicious code in FT_Set_Renderer

[Siege]

Hello everyone.

Sorry if i'm writing to wrong mail-list.
While browsing freetype code I notice following code in FT_Set_Renderer 
(src/base/ftobjs.c, v2.4.4 release):

    if ( num_params > 0 )
    {
      FT_Renderer_SetModeFunc  set_mode = renderer->clazz->set_mode;


      for ( ; num_params > 0; num_params-- )
      {
        error = set_mode( renderer, parameters->tag, parameters->data );
        if ( error )
          break;
      }
    }

I believe that iteration over parameters expected here. Like:

--- src/base/ftobjs.c   (old)
+++ src/base/ftobjs.c   (new)
@@ -3887,6 +3887,7 @@
         error = set_mode( renderer, parameters->tag, parameters->data );
         if ( error )
           break;
+        parameters++;
       }
     }
 
Since I'm not familiar with freetype internals and it is not important to my 
usage I desided just send this to you for future investigation.

Best regards, Kirill Tishin.