Re: [ft-devel] suspicious code in FT_Set_Renderer

[Werner LEMBERG]

> While browsing freetype code I notice following code in
> FT_Set_Renderer (src/base/ftobjs.c, v2.4.4 release):
> 
>     if ( num_params > 0 )
>     {
>       FT_Renderer_SetModeFunc  set_mode = renderer->clazz->set_mode;
> 
> 
>       for ( ; num_params > 0; num_params-- )
>       {
>         error = set_mode( renderer, parameters->tag, parameters->data );
>         if ( error )
>           break;
>       }
>     }
> 
> I believe that iteration over parameters expected here. Like:
> 
> --- src/base/ftobjs.c (old)
> +++ src/base/ftobjs.c (new)
> @@ -3887,6 +3887,7 @@
>          error = set_mode( renderer, parameters->tag, parameters->data );
>          if ( error )
>            break;
> +        parameters++;
>        }
>      }

Have you seen the `num_params--' in the `for' loop?  It starts with
num_params, then comes num_params-1, num_params-2, etc.


    Werner